Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added generic terms #567

Merged
merged 1 commit into from
Jan 22, 2024
Merged

added generic terms #567

merged 1 commit into from
Jan 22, 2024

Conversation

cbizon
Copy link
Contributor

@cbizon cbizon commented Jan 21, 2024

This PR adds some very generic terms to the blocklist. This set is created by parsing the Babel output to pull out anything with an information content below 40. Then, that initial list of terms was hand-filtered to keep anything that seemed keepable. The cutoff of 40 acts differently across different hierarchies so it is only a rough filter and requires some hand-tuning.

@cbizon cbizon requested a review from MarkDWilliams as a code owner January 21, 2024 18:22
Copy link
Collaborator

@MarkDWilliams MarkDWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should reconfigure this to have a human readable name alongside the CURIE, but for now, I trust you Chris!

@MarkDWilliams MarkDWilliams merged commit 1d854db into NCATSTranslator:master Jan 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants