Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NodeBinding description and add NodeBinding.query_id #304

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix NodeBinding description and add NodeBinding.query_id #304

merged 1 commit into from
Dec 21, 2021

Conversation

edeutsch
Copy link
Collaborator

@edeutsch edeutsch commented Dec 1, 2021

Addresses #293

@edeutsch edeutsch merged commit dc6e864 into 1.3 Dec 21, 2021
@edeutsch edeutsch deleted the edeutsch-NodeBinding-query_id branch July 6, 2022 03:57
gaurav added a commit to ExposuresProvider/cam-kp-api that referenced this pull request Aug 17, 2022
@gaurav
Updated NodeBinding to TRAPI 1.3.
f6ac45b 
As per the model described in https://github.com/NCATSTranslator/ReasonerAPI/blob/1e0795a1c4ff5bcac3ccd5f188fdc09ec6bd27c3/TranslatorReasonerAPI.yaml#L468-L505

Includes TRAPI model changes from:
- NCATSTranslator/ReasonerAPI#304
- NCATSTranslator/ReasonerAPI#312
@gaurav gaurav mentioned this pull request Aug 17, 2022
Merged
gaurav added a commit to ExposuresProvider/cam-kp-api that referenced this pull request Aug 25, 2022
@gaurav
Update TRAPI model to 1.3 (#559)
82ca402 
This PR updates the TRAPI model to TRAPI 1.3. This includes:
- Removed the TRAPISubAttribute type and allow attributes to have TRAPIAttributes of their own. See [TRAPI model change](NCATSTranslator/ReasonerAPI@6ec8ea2) and [TRAPI ChangeLog](https://github.com/NCATSTranslator/ReasonerAPI/blob/7520ac564e63289dffe092d4c7affd6db4ba22f1/ChangeLog.md).
  - This requires making some usages `lazy` so that they can recursively refer to themselves.
- Updated TRAPINodeBinding to the model described in https://github.com/NCATSTranslator/ReasonerAPI/blob/1e0795a1c4ff5bcac3ccd5f188fdc09ec6bd27c3/TranslatorReasonerAPI.yaml#L468-L505, which includes changes from:
  - NCATSTranslator/ReasonerAPI#304
  - NCATSTranslator/ReasonerAPI#312
@edeutsch edeutsch mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyTa CaseyTa CaseyTa approved these changes

@marcdubybroad marcdubybroad marcdubybroad approved these changes

@MarkDWilliams MarkDWilliams MarkDWilliams approved these changes

@brettasmi brettasmi brettasmi approved these changes

@bill-baumgartner bill-baumgartner bill-baumgartner approved these changes

@kshefchek kshefchek kshefchek approved these changes

@kennethmorton kennethmorton kennethmorton approved these changes

@stevencox stevencox stevencox approved these changes

@tziomics tziomics Awaiting requested review from tziomics

@vdancik vdancik Awaiting requested review from vdancik

@webyrd webyrd Awaiting requested review from webyrd

@yakaboskic yakaboskic Awaiting requested review from yakaboskic

@andrewsu andrewsu Awaiting requested review from andrewsu

@RichardBruskiewich RichardBruskiewich Awaiting requested review from RichardBruskiewich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@edeutsch @stevencox @kennethmorton @kshefchek @bill-baumgartner @brettasmi @MarkDWilliams @marcdubybroad @CaseyTa