Link netCDF-C via pkgconfig #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferences when linking against a static libnetcdf-fortran.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 79.07% 79.07%
=======================================
Files 126 126
Lines 11104 11104
=======================================
Hits 8780 8780
Misses 2324 2324 ☔ View full report in Codecov by Sentry. |
K20shores
approved these changes
May 21, 2024
|
I see one of the |
This happens occasionally - I'll just merge it in and the tests should rerun after the commit to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linking against static
netcdf-fortran, there are many unresolved symbols from the netcdf-c library. This finds and links against the C library and resolves the issue, at least in my testing.