Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XNO2 photolysis configurations for TS mechanisms #31

Merged
merged 10 commits into from
Jan 19, 2024

Conversation

mattldawson
Copy link
Collaborator

closes #21

Updates the TS1/TSMLT example configuration to use Doug's provided algorithms/data sets for BrONO2 and HO2NO2. This required modifying the temperature dependent cross-section type to accept additional temperature parameterization algorithms, and adding a specified override range option for the base cross section.

The HO2NO2 + hv -> OH + NO3 reaction did not exist in the TS1/TSMLT configuration, so it was added.

@codecov-commenter
Copy link

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (2d9db9c) 77.48% compared to head (15fd74e) 77.74%.

Files Patch % Lines
...oss_sections/util/temperature_parameterization.F90 87.69% 16 Missing ⚠️
...til/temperature_parameterization_taylor_series.F90 86.07% 11 Missing ⚠️
src/cross_sections/util/temperature_range.F90 60.00% 8 Missing ⚠️
...s/util/temperature_parameterization_burkholder.F90 92.42% 5 Missing ⚠️
src/cross_sections/temperature_based.F90 88.46% 3 Missing ⚠️
src/quantum_yield.F90 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   77.48%   77.74%   +0.25%     
==========================================
  Files         109      113       +4     
  Lines        8689     8869     +180     
==========================================
+ Hits         6733     6895     +162     
- Misses       1956     1974      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattldawson mattldawson merged commit f371af0 into main Jan 19, 2024
10 checks passed
@mattldawson mattldawson deleted the develop-21-no2-cross-sections branch January 19, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add temperature-dependent cross sections needed for TSMLT
3 participants