-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scm_vgrid and UI #307
Conversation
…ll need to add more passthrough args for multi_run_scm.py and check operation of rt.sh; also update all case configuration files to get rid of unused namelist vars
…c variables; edit rt.sh to work with new run script; add runtime_mult argument
…for use in the run script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been quite the learning experience! Please feel free to argue against any suggested changes that you don't feel are appropriate, this has been my first time really digging in to the depths of the SCM in detail. And let me know if you have any follow-up questions.
@mkavulich Thanks for the review. I've addressed the comments. Would you mind taking another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I forgot to hit the "Approve" button earlier! Thanks for your comments and answering my questions.
This pull request addresses the following issues and discussions:
Objective 1: update the vertical grid code to match the latest FV3 code and improve vertical coordinate usability
Implications:
Objective 2: Since we needed to modify all case configuration files, use this opportunity to clean up all unnecessary case configuration namelist options
Objective 3: Clean up suite defaults
Objective 4: Add flexibility for output location