Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement timestep_init phases and catch up with master of ccpp-physics #223

Closed
wants to merge 6 commits into from

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Jan 27, 2021

  • Implement the timestep_init/finalize phases in SCM source code
  • update to ccpp-physics master as of 2021/01/26
  • change build system so that ccpp_prebuild.py writes caps/cmake snippets to build directory rather than src directory (this now works with the default CMakeLists.txt in ccpp-physics)
  • change the diagnostic bucket clearing to SCM code
    -- change timing of diagnostic clearing (order of operations was wrong)
    -- allow for diagnostic clearing every timestep
  • comment out reading in RUC LSM init variables since changes to ccpp-physics has rendered it obsolete (followup PR needed to read in RUC LSM init data)

@grantfirl
Copy link
Collaborator Author

Associated PR: NCAR/ccpp-physics#562

@grantfirl
Copy link
Collaborator Author

The fix in the CMakeLists.txt for ccpp-physics in NCAR/ccpp-physics@2d8c061#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a leads to build issues in the SCM, but it is likely the SCM build system's fault.

@grantfirl
Copy link
Collaborator Author

Also, the RUC LSM code that was commented out needs to be updated following a recent change in that code.

@grantfirl grantfirl marked this pull request as ready for review March 1, 2021 22:52
scm/etc/case_config/arm_sgp_summer_1997_A.nml Outdated Show resolved Hide resolved
scm/src/GFS_typedefs.meta Outdated Show resolved Hide resolved
scm/src/gmtb_scm_time_integration.F90 Show resolved Hide resolved
…edefs.meta; update submodule pointer for ccpp-physics
@climbfuji
Copy link
Collaborator

Please let me know when you are done with the updates by requesting another review, and I'll take a look. Thanks!

@grantfirl grantfirl requested a review from climbfuji March 2, 2021 18:45
@grantfirl
Copy link
Collaborator Author

Please let me know when you are done with the updates by requesting another review, and I'll take a look. Thanks!

There definitely need to be followup PR(s) to catch up to master, but I'd like to merge this before continuing on.

@climbfuji
Copy link
Collaborator

@grantfirl I merged NCAR/ccpp-physics#562 earlier today.

@grantfirl
Copy link
Collaborator Author

@grantfirl I merged NCAR/ccpp-physics#562 earlier today.

Thanks. Did you want to review this PR again?

@grantfirl
Copy link
Collaborator Author

I'll update the submodule pointer for ccpp-physics real quick.

@grantfirl
Copy link
Collaborator Author

I'll update the submodule pointer for ccpp-physics real quick.

Nevermind. Since that PR went into top of master, that will break things. I think that I'll just need to go ahead and update the SCM to the top of master.

@climbfuji
Copy link
Collaborator

I'll update the submodule pointer for ccpp-physics real quick.

Nevermind. Since that PR went into top of master, that will break things. I think that I'll just need to go ahead and update the SCM to the top of master.

Yeah, no other choice, unfortunately. Cannot merge it somewhere in between.

@grantfirl
Copy link
Collaborator Author

I'll update the submodule pointer for ccpp-physics real quick.

Nevermind. Since that PR went into top of master, that will break things. I think that I'll just need to go ahead and update the SCM to the top of master.

Yeah, no other choice, unfortunately. Cannot merge it somewhere in between.

Totally fine. The update to top-of-master is long overdue anyway, so now is a good time.

@grantfirl
Copy link
Collaborator Author

Replaced by #239

@grantfirl grantfirl closed this Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants