-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement timestep_init phases and catch up with master of ccpp-physics #223
Conversation
Associated PR: NCAR/ccpp-physics#562 |
The fix in the CMakeLists.txt for ccpp-physics in NCAR/ccpp-physics@2d8c061#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a leads to build issues in the SCM, but it is likely the SCM build system's fault. |
Also, the RUC LSM code that was commented out needs to be updated following a recent change in that code. |
…edefs.meta; update submodule pointer for ccpp-physics
Please let me know when you are done with the updates by requesting another review, and I'll take a look. Thanks! |
There definitely need to be followup PR(s) to catch up to master, but I'd like to merge this before continuing on. |
@grantfirl I merged NCAR/ccpp-physics#562 earlier today. |
Thanks. Did you want to review this PR again? |
I'll update the submodule pointer for ccpp-physics real quick. |
Nevermind. Since that PR went into top of master, that will break things. I think that I'll just need to go ahead and update the SCM to the top of master. |
Yeah, no other choice, unfortunately. Cannot merge it somewhere in between. |
Totally fine. The update to top-of-master is long overdue anyway, so now is a good time. |
Replaced by #239 |
-- change timing of diagnostic clearing (order of operations was wrong)
-- allow for diagnostic clearing every timestep