Fix bug in CMakeLists.txt (get_filename_component was using non-existent path as BASE_DIR), use ip@5: if available instead of sp #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent path as BASE_DIR), use ip@5: if available instead of sp
climbfuji
requested review from
grantfirl,
Qingfu-Liu,
dustinswales and
mzhangw
as code owners
This was referenced Oct 7, 2024
dustinswales
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
@climbfuji Thanks for making these changes.
@grantfirl Is there and open ccpp-physics:ufs/dev PR that I(you) could add this on the UFS side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
CMakeLists.txt: The first call toget_filename_componentseems to be using an uninitialized (empty) variableLOCAL_CURRENT_SOURCE_DIRasBASE_DIRargument. It would be good if somebody could verify that.splibrary is deprecated and replaced byip@5and newer (drop-in replacement). While[email protected]is still in spack-stack-1.8.0,ip-5.0.0is also available. We expectspto be removed in spack-stack-1.9.0.Because of (2), similar changes need to be made in the host model (SCM: PR to come in a minute, UFS: someone else needs to do).
Note that I cannot compile the SCM on my laptop with GCC, because the
SCHEMES_OPENMP_OFFlogic seems to be not working as expected (with and without the change made in 1 I believe), therefore I would like to ask someone else to test these two changes, please.