-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calipso diags #245
Open
brianpm
wants to merge
20
commits into
NCAR:main
Choose a base branch
from
brianpm:calipso_diags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Calipso diags #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that from plotting scripts.
… that from plotting scripts.
The problem I mentioned above was because of typos that got propagated from my |
Just FYI, I had to make a few more changes within this branch to get ADF to successfully run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to incorporate CALIPSO observations into ADF.
The CALIPSO climo file is currently here:
/glade/work/brianpm/obs_data_for_adf/CALIPSO_GOCCP_3.1.2_climo_200606-202012.nc
This PR modifies the
adf_variable_defaults.yaml
file to include the CALIPSO variables.In doing this, I realized that
CLD_CAL
has a different vertical coordinate (cosp_ht
in CAM). This causes trouble when we hard-code tolev
. I have started to make modifications to check for any vertical coordinate by having a list of known vertical coordinates inplotting_functions.py
.I think I've got the code working for zonal and meridional plots.
BUT something strange is going on in my testing. ADF seems to be using the same data for both the model and the observations. Also, the zonal and meridional plots of
CLD_CAL
are upside down because it's height and not pressure. I will look into these, but if anyone has time to take a look at what I'm doing here, I'd very much appreciate input. (I also need to fix my change to the amwg_table.py to be consistent with the other changes.)