Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance multiple case diagnostics #229

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Enhance multiple case diagnostics #229

wants to merge 13 commits into from

Conversation

justin-richling
Copy link
Collaborator

Add multi-case diagnostics and webpages:

  • Add multi-case plot section and case nicknames to config yaml
  • Update all website templates (add new for multi-case)
  • Update web generation
  • Add multi-case subplots and all case comp tables
  • Designate hub for all test cases individual vs baseline ADF analysis

@justin-richling
Enhance multiple case diagnostics
0148619 
Add multi-case diagnostics and webpages:

- Add multi-case plot section to config yaml
- Update all website templates (add new for multi-case)
- Update web generation
- Add multi-case subplots and all case comp tables
- Designate hub for all test cases individual vs baseline ADF analysis
@nusbaume nusbaume added enhancement New feature or request config files Concerns the ADF config (YAML) files website Having to do with the generated website labels Feb 21, 2023
nusbaume
nusbaume requested changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work Justin! I have lots of small suggestions and questions, but they should all be relatively minor, as the overall structure looked good to me.

The only somewhat large change might be to manage the setting of the case nickname list in adf_info.py instead of in the various table and plotting scripts. That way any future scripts can use the nicknames directly, instead of having to do their own checking.

Anyways, please let me know if you have any questions or concerns, or need any help with any of my requests. Thanks!

lib/adf_web.py Outdated Show resolved Hide resolved
lib/adf_web.py Outdated Show resolved Hide resolved
lib/adf_web.py Show resolved Hide resolved
lib/adf_web.py Outdated Show resolved Hide resolved
lib/adf_web.py Outdated Show resolved Hide resolved
scripts/analysis/amwg_table.py Outdated Show resolved Hide resolved
scripts/plotting/global_latlon_map.py Outdated Show resolved Hide resolved
scripts/plotting/global_latlon_map.py Outdated Show resolved Hide resolved
scripts/plotting/global_latlon_map.py Outdated Show resolved Hide resolved
scripts/plotting/global_latlon_map.py Outdated Show resolved Hide resolved
@justin-richling
Fix PR suggestions for multi-case
7457d89 
Also fix small bugs:
* Move RESTOM to top of AMWG tables
* Missing check for len of climo files in regrid_and_vert_interp (fixes part of Issue NCAR#228)
* Special plots didn't work with multi-case diags initially
@justin-richling
Clean up GitHub source_code_tests errors
2e55128
@justin-richling
Remove print statement
c77a964
@justin-richling justin-richling mentioned this pull request Mar 28, 2023
Open
@justin-richling
Finish PR fixes
29f23b8 
Also clean up `adf_web` and html pages a bit more
@justin-richling
Clean up source_code_tests warnings
d96021b
@justin-richling
Update adf_web.py
d3f4f43 
Need second set of parenthesis to get correct if comparison
@justin-richling
Copy link
Collaborator Author

@nusbaume I think I've gotten all your suggestions and a couple more fixes that cropped up. I cleaned up a lot of the jinja rendering arguments in adf_web too, hopefully this cleans up the code a decent amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nusbaume nusbaume Awaiting requested review from nusbaume

Assignees

@nusbaume nusbaume

@justin-richling justin-richling

Labels
config files Concerns the ADF config (YAML) files enhancement New feature or request website Having to do with the generated website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin-richling @nusbaume