Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom AoI upload #703

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

nerik
Copy link
Contributor

@nerik nerik commented Oct 17, 2023

Migrates the previous upload custom AoI modal to the Exploration page.

Screenshot 2023-10-17 at 15 12 35

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit d3d37bd
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/653116001516160008855a8e
😎 Deploy Preview https://deploy-preview-703--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nerik nerik changed the title Set up trigger button and modal Custom AoI upload Oct 17, 2023
@nerik nerik marked this pull request as ready for review October 17, 2023 13:14
@nerik nerik force-pushed the feature/exploration-map-aoi-upload branch from 84aa1be to 496301b Compare October 17, 2023 13:15
Base automatically changed from feature/exploration-map-controls-polish to feature/exploration October 17, 2023 13:42
Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not part of this PR, but could be good to allow the user to clear all the AOIs by pressing the trash can with nothing selected.

Co-authored-by: Daniel da Silva <danielfdsilva@gmail.com>
@nerik nerik force-pushed the feature/exploration-map-aoi-upload branch from 6ec9172 to d3d37bd Compare October 19, 2023 11:41
@nerik nerik merged commit ce2f577 into feature/exploration Oct 19, 2023
@nerik nerik deleted the feature/exploration-map-aoi-upload branch October 19, 2023 11:44
@nerik
Copy link
Contributor Author

nerik commented Oct 19, 2023

@danielfdsilva Good suggestion. I don't see any other way to implement this (ie adding a custom listener on the trash button) than to rebuild the control from scratch, thoughts?

@danielfdsilva
Copy link
Collaborator

Yeah... seems to be that way. I've rarely used the default controls. For the current analysis I had created custom ones and then handled the events as I needed.

@danielfdsilva
Copy link
Collaborator

There could be also an additional button to do that, maybe it is also clearer? like a reset?
The current analysis uses the arrows one:
image

@nerik nerik mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants