-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom AoI upload #703
Custom AoI upload #703
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
84aa1be
to
496301b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not part of this PR, but could be good to allow the user to clear all the AOIs by pressing the trash can with nothing selected.
app/scripts/components/common/map/controls/aoi/custom-aoi-control.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel da Silva <danielfdsilva@gmail.com>
6ec9172
to
d3d37bd
Compare
@danielfdsilva Good suggestion. I don't see any other way to implement this (ie adding a custom listener on the trash button) than to rebuild the control from scratch, thoughts? |
Yeah... seems to be that way. I've rarely used the default controls. For the current analysis I had created custom ones and then handled the events as I needed. |
Migrates the previous upload custom AoI modal to the Exploration page.