Do not pass initial position at all if there is none #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
fix/initialposition
branch
from
d12b444 to
b13279b
Compare
|
@hanbyul-here Do you need a review here? Should this be merged into |
|
yeah thank you @nerik . |
nerik
approved these changes
Oct 6, 2023
Merged
hanbyul-here
added a commit
that referenced
this pull request
Oct 12, 2023
## This PR, merged to `ghg` ### Features - Analysis define - New step-by-step layout and various UI tweaks - Added sticky footer, moved submit and cancel buttons there - Added an AoI preset for North America - Datasets are not filtered from `/collections` metadata (spatial, temporal extent) - Dates are now set by default to 2018 - 2022 - Replaced date presets with "2018 - 2022" and "last 10 years" - Date selection not possible anymore before 01-01-1980 - Prevent users from selecting datasets when time range selected would mean fetching too many STAC items - Analysis results page: set a hardcoded limit on the number of items that can be requested as a failsafe mechanism for ☝️ ### Bugfixes - Removed logs in production (US-GHG-Center/veda-config-ghg#152) - Temporary fix of critical error encoutered during demos (#680) - Remove Shadow Scroll as a preventative method for (#691) - Check only day level equity to validate dates (#676) - Remove unneded attributes (#694) - BlockMap initial position error (#687) ### Copy changes - [Updated define copy](f1e7171) - [Disclaimer on results page](54cf01e) --- ## Other PRs, merged to `main` ### Added in veda UI but made configurable (so not affecting veda-config): - #673 - #665 - #664 ### Bugfixes - #672 - #670 / #666 - #662 - #691 - #650 - #676 - #694 - #687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the bug where we pass
initialPositionprop even when there is none defined by an editor.