Raster timeseries #655
Merged
Raster timeseries #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nerik
force-pushed
the
feature/exploration-map-layers
branch
from
0b8a66b to
5e21005
Compare
nerik
force-pushed
the
feature/exploration-map-layers
branch
from
5e21005 to
70d0782
Compare
Base automatically changed from
feature/exploration-map-controls
to
feature/exploration
September 18, 2023 13:39
| @@ -11,7 +11,7 @@ import { | |||
| } from 'mapbox-gl'; | |||
There was a problem hiding this comment.
Please remind me:
I recall us having a discussion about whether or not to make the STAC layer data requests outside the layer component. Did we end up deciding to keep it this way because of how tightly coupled with the rendering these requests are?
There was a problem hiding this comment.
If I remember correctly, we opted to keep the STAC layer data requests inside the component/generator because the results from those requests are only relevant to the map.
A recap for my own sanity:
search-> get STAC features -> used to render points layer, if anymosaic/register-> get tilejson url- `mosaic/[id]/tilejson.json -> get XYZ tiles URL -> used to render raster tiles
There was a problem hiding this comment.
Yes, that is correct
danielfdsilva
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds raster timeseries back to the new map component with some architecture fixes (please review ignoring the first commit which was mostly copying files from the old version around).