Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploration map controls #651

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Conversation

nerik
Copy link
Contributor

@nerik nerik commented Sep 11, 2023

Adds coords, scale, zoom, and map options controls, on both compare maps.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 8322abf
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/65084fe9b304770008fcb775
😎 Deploy Preview https://deploy-preview-651--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nerik nerik changed the base branch from main to feature/exploration September 11, 2023 13:05
@nerik nerik marked this pull request as ready for review September 12, 2023 08:15
@nerik nerik requested a review from danielfdsilva September 12, 2023 08:17
@nerik nerik force-pushed the feature/exploration-map-controls branch from cbc907c to f1f0204 Compare September 12, 2023 08:43
Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! A couple of things:

  • Selecting a different base style does not update the compare map (the projection does)
  • We should disable the pitch change (right mouse click)

@nerik nerik requested a review from danielfdsilva September 14, 2023 09:08
@nerik nerik force-pushed the feature/exploration-map-controls branch from d3314dd to f027c94 Compare September 14, 2023 09:10
Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basemap now updates both maps and the pitch was disabled.
However, the "labels" and "boundaries" are only toggled for the main map

@danielfdsilva danielfdsilva self-requested a review September 18, 2023 13:26
Copy link
Collaborator

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nerik I went ahead and fixed the labels and boundaries issue to speed up things.

This is good to go! :shipit:

@nerik nerik merged commit 560fdd7 into feature/exploration Sep 18, 2023
8 checks passed
@nerik nerik deleted the feature/exploration-map-controls branch September 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants