chore: Include only lib folder when publishing, Add Dataset and Story data type to export #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
changed the title
dzole0311
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Tested the publishing of the package, works as expected (the tarball from Verdaccio contains only the lib as a directory) ✅
@hanbyul-here The README.md and package.json that correspond to the veda-ui are also published. Not a blocker, but I guess we should eventually update these as well (e.g. README.md specific to the library)?
|
@dzole0311 Yah good point - we can't separate package.json but we probably can do something better for README before we actually start publishing to npm registry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are publishing everything in the folder which should not be necessary. Explicitly scope the folder to publish (
filesinpackage.json)Also add more types to export (Dataset, Story)