fix: hideFooter prop name, small cleanup #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@AliceR This looks great! I see that some other work streams got pulled into the dif. If there is anyway we can get that cleaned up prior to merger so we don't cause confusion in the final review. Once that's done I am good to approve and merge! |
AliceR
force-pushed
the
1135-fix-propname
branch
from
af6de5b to
fe545d4
Compare
AliceR
changed the title
|
Ok sure, I removed the merge commit. Also noting, the tests are failing on the feature branch, they just don't run there because it in draft mode. |
AliceR
merged commit 02e5b61
into
1135-Refactor-Layout-Components-Footer
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @snmln , I fixed the prop name, did some cleanup in the css styles and merged the main branch.