refactor: 1135 slim footer #1308
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
snmln
changed the base branch from
main
to
1135-Refactor-Layout-Components-Footer
| returnToTop: true | ||
| }; | ||
|
|
||
| const defaultFooterPrimaryContactItems = [ |
There was a problem hiding this comment.
do we want the footer items to be different from the header? In my understanding, it was just a repetition of the main nav items - which would mean we should use the same configuration that we base the header on.
There was a problem hiding this comment.
As I was working through this, this question came up and I think we should discuss further. My thoughts are that we can and should model the footer materials after the header data model. But the instances are going to request for individualized configurability of the footer so they can customize past the header navigation. What are your thoughts?
There was a problem hiding this comment.
This sounds like a good case for YAGNI - let's wait for that request to come in first :)
There was a problem hiding this comment.
I would agree but I am concerned that this configurability potentially falls under this AC from the main ticket:
Composite Feature should be entirely data agnostic => Separate out the data logic from this feature component into the data layer.
| & > .grid-container { | ||
| max-width: 100%; | ||
| padding: 0; | ||
| //NEED to determine how to remove 64rem max-width on grid-container |
There was a problem hiding this comment.
why do we need to remove the max-width? This is the desktop breakpoint afaik
There was a problem hiding this comment.
Correct, the existing footer function when at desktop view expands to the full width of the entire window. With this USWDS max-width in place it only allows for it to stretch to 64rem and leaves pretty large gutters on either side: Example: https://trussworks.github.io/react-uswds/iframe.html?args=&id=components-footer--slim-footer&viewMode=story
This might be more of a @faustoperez question. At desktop do we want the large gutter to the left and right of the footer content at desktop or do we want the content to stretch to full width of the screen?
There was a problem hiding this comment.
IMO we should follow the header and leave the gutter. If I understand it correctly we wil have a page layout later that will align all the components on a page.
There was a problem hiding this comment.
The footer is taking shape, thank you @snmln 🙌
The only thing that requires an actual conversation is the change to the configuration: I am questioning if this is necessary at all. Could we generate the footer from everything that we already have in the config for the header?
|
Merging this into the main feature branch. @AliceR if you could implement the nav elements how you see fit and leverage the main nav items from veda config i think we should be good to keep this moving. |
snmln
merged commit 4bdf994
into
1135-Refactor-Layout-Components-Footer
Related Ticket: {link related ticket here}
Description of Changes
Creating slim footer.
TO DO's for this PR: