Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding "release" to task_types #1302

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

snmln
Copy link
Contributor

@snmln snmln commented Dec 6, 2024

Related Ticket: #1301

Description of Changes

Adding "release" to task_type

@snmln snmln requested review from hanbyul-here and AliceR December 6, 2024 16:21
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit ba388e8
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/6753248b6ffbc80008e23c28
😎 Deploy Preview https://deploy-preview-1302--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@snmln snmln changed the title CI: Adding "release" to task_types fix: Adding "release" to task_types Dec 6, 2024
@snmln snmln linked an issue Dec 6, 2024 that may be closed by this pull request
@snmln snmln mentioned this pull request Dec 6, 2024
Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Dec 9, 2024

I think we might need release prefix for some hotfixes in the future - but I just want to make it clear that we now want the release to happen automatically, not through the PR. Attaching a PR that automates the release: https://github.com/NASA-IMPACT/veda-ui/pulls?q=is%3Apr+is%3Aclosed -

We won't need to do this PR anymore: #1300 since release action should take care of it. (The changelog might not be perfect this time but it will only get better as we adopt Conventional Commit)

Also, these prefixes are tied to the automatic version number bump - We can find which prefix is tied to which version number through Conventional Commit doc: https://github.com/conventional-changelog/conventional-changelog-config-spec/blob/master/versions/2.2.0/README.md#types

@snmln snmln merged commit 6ac398a into main Dec 9, 2024
11 of 12 checks passed
@snmln snmln deleted the CI--automation-release-addition branch December 9, 2024 15:00
@hanbyul-here
Copy link
Collaborator

I just realized that our automatic release uses chore(release): as a prefix, can we also follow that pattern instead of the. new prefix? 455a563#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding task_type of 'release' to Pr title check
3 participants