Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] Bump minor to v5.11.0 #1274

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[RELEASE] Bump minor to v5.11.0 #1274

merged 1 commit into from
Nov 26, 2024

Conversation

dzole0311
Copy link
Collaborator

@dzole0311 dzole0311 commented Nov 25, 2024

🚀 Improvements

🐛 Fixes

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit b4556ef
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/67446b5739b92900088fd6a9
😎 Deploy Preview https://deploy-preview-1274--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aboydnw
Copy link
Contributor

aboydnw commented Nov 25, 2024

Charts now show standard deviation, similar to what we reported in #1256

Do we understand yet why this is happening? It might be okay with our instances, but we'd have to let them know about the change, why it happens, and how they can control it. For example, in #1256 I point out some of the charts show min/max and I don't know why. None of the layers in the preview show min/max
image

Maybe worth creating a preview in GHG to see what the charts look like there?

@aboydnw
Copy link
Contributor

aboydnw commented Nov 25, 2024

I spoke too soon. NO2 PT shows min/max. Any ideas why?
image

@hanbyul-here
Copy link
Collaborator

@aboydnw Editors can add their own metrics through analysis.metrics : https://github.com/NASA-IMPACT/veda-ui/blob/main/docs/content/frontmatter/layer.md#analysis And NO2 PT data has min and max as its values: https://raw.githubusercontent.com/NASA-IMPACT/veda-ui/refs/heads/main/mock/datasets/no2.data.mdx - Is this the problem you are observing? Or am I missing anything?

@aboydnw
Copy link
Contributor

aboydnw commented Nov 26, 2024

Ah okay, I didn't know that was possible. That was part of the question I called out in #1256

so, maybe no problem, although I don't remember ever seeing these different chart types in previews before (I might have just missed it)

Do we think GHG and others know about this functionality?

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Nov 26, 2024

I can't remember the exact context but I believe it was the feature implemented by request (not sure if it was by GHG) so at least the people who requested this should know.

@dzole0311
Copy link
Collaborator Author

@aboydnw I’ve set up a preview in the GHG instance in case you want to have a quick look (I couldn't spot any issues): https://deploy-preview-677--ghg-demo.netlify.app/

Screenshot 2024-11-26 at 12 36 22

Copy link
Contributor

@aboydnw aboydnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all. I agree, looks good to me.

@dzole0311 dzole0311 merged commit 9132e6d into main Nov 26, 2024
9 checks passed
@dzole0311 dzole0311 deleted the release/5.11.0 branch November 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants