-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1238] Create a derived atom for dataset hydration from Next.js #1266
Merged
dzole0311
merged 2 commits into
main
from
1238-provide-setter-atom-for-hydrating-datasets
Nov 25, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import { atom } from 'jotai'; | ||
import { DatasetLayer } from '$types/veda'; | ||
|
||
/** | ||
* This is the primary storage atom for external datasets (e.g. passed from Next.js). | ||
*/ | ||
export const externalDatasetsAtom = atom<any[]>([]); | ||
|
||
/** | ||
* Derived atom that transforms the provided datasets into layers. | ||
* It is used by the timelineDatasetsAtom to rebuild state from URL parameters | ||
* while it preserves the parent dataset metadata for each layer that comes | ||
* from the MDX configuration. | ||
*/ | ||
export const datasetLayersAtom = atom<DatasetLayer[]>((get) => { | ||
const datasets = get(externalDatasetsAtom); | ||
|
||
return datasets.flatMap((dataset) => { | ||
return (dataset.layers || []).map((l: any) => ({ | ||
...l, | ||
parentDataset: { | ||
id: dataset.id, | ||
name: dataset.name | ||
} | ||
})); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current approach using
setExternalDatasets
works, but it might need to be called in multiple places where we depend on the static datasets.I was wondering if a more scalable solution would be to use our existing
EnvConfigProvider
and evolve it into a more generalConfigProvider
. Like this it would centralize both our env and data configuration in one place.The provider could be used like this (note the extra datasets prop passed):
And internally, the provider would handle dataset hydration:
Like that the setter won't have to be manually called several times if it's needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How you described makes sense. My concern for now is how nicely it would work out irl considering Jotai positions itself as a replacement for context (I am reading https://jotai.org/docs/basics/comparison) - or it just means that we are really not taking full advantage of Jotai. I will put more thoughts into this from the perspective of global state management.