updating styles

NASA-IMPACT · Dec 10, 2024 · d0a4cd4 · d0a4cd4
1 parent a7a91ec
commit d0a4cd4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/app/scripts/components/common/page-footer/index.tsx b/app/scripts/components/common/page-footer/index.tsx
@@ -1,5 +1,6 @@
 import React from 'react';
 import { Icon } from '@trussworks/react-uswds';
+//TO DO: need to move NasaLogoColor outside of component and pass down as props
 import NasaLogoColor from '../../nasa-logo-color.js';
 import {
   USWDSFooter,
@@ -13,7 +14,7 @@ interface PageFooterProps {
   settings: any;
   hidefooter?: boolean;
 }
-
+//TODO: clean up PageFooterProps
 export default function PageFooter({
   settings,
   primarySection,
@@ -45,7 +46,7 @@ export default function PageFooter({
         primary={
           <div
             id='footer_primary_container'
-            className=' grid-row bg-base-lightest'
+            className=' grid-row bg-base-lightest usa-footer__primary-container'
           >
             <div className='mobile-lg:grid-col-8'>
               <USWDSFooterNav
@@ -61,6 +62,7 @@ export default function PageFooter({
             <div className='tablet:grid-col-4'>
               <USWDSAddress
                 size='slim'
+                id='footer_address_links'
                 className='flex-justify-end'
                 items={[
                   <a className='usa-link text-base-dark' key='#' href='#'>

diff --git a/app/scripts/components/common/page-footer/styles.scss b/app/scripts/components/common/page-footer/styles.scss
@@ -21,12 +21,6 @@
      */
   }
 
-  // @media (width <= themeVars.$veda-uswds-spacing-desktop) {
-  //   #nasa-logo-pos {
-  //     display: none;
-  //   }
-  // }
-
   svg {
     height: 2.75rem;
     width: auto;
@@ -43,21 +37,16 @@
 
 #return-to-top-container {
   padding: themeVars.$veda-uswds-padding-4 themeVars.$veda-uswds-padding-5;
+  max-width: 64rem;
 }
 #footer_primary_container {
   padding: themeVars.$veda-uswds-padding-4 themeVars.$veda-uswds-padding-5;
   background-color: themeVars.$veda-uswds-color-base-lightest;
 }
-
 .usa-footer__secondary-section {
   background-color: themeVars.$veda-uswds-color-base-darkest;
-  padding: themeVars.$veda-uswds-padding-4 themeVars.$veda-uswds-padding-5;
-  & > .grid-container {
-    max-width: 100%;
-    padding: 0;
-    //NEED to determine how to remove 64rem max-width on grid-container
-  }
 }
+
 .usa-footer__primary-section {
   background-color: themeVars.$veda-uswds-color-base-lightest;
 }
@@ -70,3 +59,7 @@
 .usa-footer__address > .grid-row {
   justify-content: flex-end;
 }
+#footer_address_links {
+  color: themeVars.$veda-uswds-color-base-dark;
+  font-style: normal;
+}