Review updates (#652)

# Changes - Open data usage links in a new tab - Open Hub in a new tab - Allow specifying banner images for the development and about pages
NASA-IMPACT · Sep 13, 2023 · c88145f · c88145f
2 parents 5b70832 + 68f9a36
commit c88145f
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/app/scripts/components/about/index.tsx b/app/scripts/components/about/index.tsx
@@ -18,6 +18,10 @@ function About() {
         description={
           aboutContent?.data.description || 'This is the default description'
         }
+        coverSrc={aboutContent?.data.media?.src}
+        coverAlt={aboutContent?.data.media?.alt}
+        attributionAuthor={aboutContent?.data.media?.author?.name}
+        attributionUrl={aboutContent?.data.media?.author?.url}
       />
       <ContentOverride with='aboutContent'>
         <FoldProse>

diff --git a/app/scripts/components/common/google-form.tsx b/app/scripts/components/common/google-form.tsx
@@ -53,7 +53,7 @@ function GoogleForm() {
         onClick={show}
         style={{ color: 'white' }}
       >
-        Feedback
+        Contact Us
       </ButtonAsNavLink>
       <Modal
         id='modal'

diff --git a/app/scripts/components/common/notebook-connect.tsx b/app/scripts/components/common/notebook-connect.tsx
@@ -134,7 +134,7 @@ export function NotebookConnectModal(props: {
           <DatasetUsages>
             {datasetUsagesWithIcon.map((datasetUsage) => (
               <li key={datasetUsage.url}>
-                <DatasetUsageLink href={datasetUsage.url}>
+                <DatasetUsageLink href={datasetUsage.url} target='_blank' rel='noopener'>
                   {IconByType[datasetUsage.type]}
                   <DatasetUsageLabel>
                     <h4>{datasetUsage.title}</h4>

diff --git a/app/scripts/components/common/page-header.tsx b/app/scripts/components/common/page-header.tsx
@@ -408,7 +408,7 @@ function PageHeader() {
                       to={ANALYSIS_PATH}
                       onClick={closeNavOnClick}
                     >
-                      Analysis
+                      Data Analysis
                     </GlobalMenuLink>
                   </li>
                   <li>
@@ -426,14 +426,15 @@ function PageHeader() {
                     <li>
                       <GlobalMenuLink
                         as='a'
+                        target='_blank'
+                        rel='noopener'
                         href={process.env.HUB_URL}
                         onClick={closeNavOnClick}
                       >
                         {process.env.HUB_NAME}
                       </GlobalMenuLink>
                     </li>
                   )}
-
                 </GlobalMenu>
               </SectionsNavBlock>
               <SectionsNavBlock>

diff --git a/app/scripts/components/development/index.tsx b/app/scripts/components/development/index.tsx
@@ -34,6 +34,10 @@ function Development() {
           developmentContent?.data.description ||
           'Visualization, Exploration, and Data Analysis (VEDA): Scalable and Interactive System for Science Data.'
         }
+        coverSrc={developmentContent?.data.media?.src}
+        coverAlt={developmentContent?.data.media?.alt}
+        attributionAuthor={developmentContent?.data.media?.author?.name}
+        attributionUrl={developmentContent?.data.media?.author?.url}
       />
 
       <ContentOverride with='developmentContent'>