fix: Update search limit to maximum to encompass <12k results without exce… #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eding max offset of 10,000
chuckwondo
approved these changes
Nov 21, 2024
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
This PR is motivated by this issue, #45
Specifically I am updating the OpenSearch limit to the maximum value (2000) to quickly mitigate an issue surfaced when ESA updated the maximum query offset we could apply. This fix relies on an assumption that there are less than 12,000 search results for a given day. This assumption matches what I've seen for queries over the last week where we're getting between ~10,000 and ~10,500 total results.
How I did it
maxResultsto the maximum allowedmaxResults=2000How you can test it
Unit tests have been updated,