Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Two Column to work with Delta Urls #1103

Merged
merged 23 commits into from
Dec 6, 2024
Merged

Refactor Two Column to work with Delta Urls #1103

merged 23 commits into from
Dec 6, 2024

Conversation

Kirandawadi
Copy link
Collaborator

@Kirandawadi Kirandawadi commented Nov 21, 2024 •
edited
Loading

Description

  • Develop Two Column Code to work with Delta Urls
  • Write test cases for paired field descriptor system for TDAMM tags that handles both manual and ML-generated tags.

Implementation Considerations

  • Develop paired_field_descriptor that will automatically create two fields (ML and manual) once defined inside the BaseUrl model
  • Write test cases with PyTest

Deliverable

All test cases implemented and passing:

  • Test the relationship between manual and ML fields
  • Test that manual field takes priority over ML field
  • Test handling of empty arrays vs None
  • Test deletion of fields
  • Test handling of multiple tags
  • Test that values persist after save
  • Test that tags are preserved even after collection migration and promotion

Dependencies

No response

Kirandawadi and others added 17 commits October 29, 2024 23:09
@Kirandawadi
add PairedFieldDescriptor two-column tag model
f4849e8
@Kirandawadi
add fields to admin panel
a469ef1
@Kirandawadi
moved tdamm_tags feature from collection to candidate_url
8e8e0ac
@Kirandawadi
refactor code
f5c69bd
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7e888e8 
for more information, see https://pre-commit.ci
@Kirandawadi
modify architecture to define one single field to generate two
1b9d800
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
74b5b76 
for more information, see https://pre-commit.ci
@Kirandawadi
fix flake8 issues
3ee8845
@Kirandawadi
refactor code for admin panel handling TDAMM
13649ae
@Kirandawadi
add TDAMM_TAG_CHOICES to collection_choice_fields
a5a408c
@Kirandawadi
delete is_tdamm switch functionality
e8b0cf0
@Kirandawadi
add test cases for two column tags functionality
b65c693
@pre-commit-ci @Kirandawadi
[pre-commit.ci] auto fixes from pre-commit.com hooks
0707500 
for more information, see https://pre-commit.ci
@Kirandawadi
merge 1051-backend-model-changes-on-cosmos-to-hold-new-incoming-urls-…
1a2e792 
…frontend branch
@Kirandawadi
refactor code for DeltaUrl model
e45eeeb
@Kirandawadi
add tdamm_tag field to new serializers
ff1484b
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
70ccb2c 
for more information, see https://pre-commit.ci
@Kirandawadi Kirandawadi linked an issue Nov 21, 2024 that may be closed by this pull request
Refactor Two Column to work with Delta Urls ( Tests Included) #1098
Closed
@Kirandawadi Kirandawadi changed the title 1093 write tests for two column tags functionality Refactor Two Column to work with Delta Urls Nov 21, 2024
This was referenced Nov 21, 2024
Closed
Closed
Base automatically changed from 1051-backend-model-changes-on-cosmos-to-hold-new-incoming-urls-frontend to dev November 21, 2024 14:15
@Kirandawadi Kirandawadi self-assigned this Nov 21, 2024
CarsonDavis
CarsonDavis reviewed Dec 5, 2024
View reviewed changes
sde_collections/tests/test_tdamm_tags.py
url.tdamm_tag = ["MMA_M_EM"]
url.tdamm_tag_ml = ["MMA_M_G"]

# Delete tdamm_tag
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but lets write a doc that shows this behavior.

CarsonDavis
CarsonDavis approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@CarsonDavis CarsonDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarsonDavis CarsonDavis merged commit b001d04 into dev Dec 6, 2024
5 checks passed
@CarsonDavis CarsonDavis deleted the 1093-write-tests-for-two-column-tags-functionality branch December 6, 2024 00:04
@CarsonDavis CarsonDavis restored the 1093-write-tests-for-two-column-tags-functionality branch December 6, 2024 00:05
@CarsonDavis CarsonDavis deleted the 1093-write-tests-for-two-column-tags-functionality branch December 6, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonDavis CarsonDavis CarsonDavis approved these changes

Assignees

@Kirandawadi Kirandawadi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Two Column to work with Delta Urls ( Tests Included)
2 participants
@Kirandawadi @CarsonDavis