Provide missing pfs stub functions #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Mr-Wiseguy
approved these changes
Jun 18, 2024
AngheloAlf
force-pushed
the
28-implement-the-following-libultra-functions-for-harvest-moon-64
branch
from
dbed7fa to
dfc9155
Compare
AngheloAlf
deleted the
28-implement-the-following-libultra-functions-for-harvest-moon-64
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide stubs for
osPfsNumFilesandosPfsRepairId. Those are used by games that use the Controller Pak like Harvest Moon 64 (issue #28 )I also changed
osPiRawStartDmato present an error to the user if it ever gets called, since most games do not use that function directly. Also addedosEPiRawStartDmawith the same error message.This error message would allow properly linking some recompiled games that may reference this function on the recompiled functions list and would allow catching at runtime the user not properly naming their libultra functions.