Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
gpr
casts to the arguments of theMEM_
macros to ensure the arithmetic is done as 64bits instead of something dumb because the caller passed 32bits unsigned values or similar. I also addedULL
suffix to those big constants in the macro to ensure nothing will do something dumb.I also changed
save_write
to use asize_t
instead ofuint32_t
because that's the function that gave me problems in the first placeThis PR was originally made in Zelda64Recomp/Zelda64Recomp#136