Bugfix: Correct Cookies (#5)

* yaml * banner handling * script * cookie-correct-implementation * set fun cookie * build script * update version
MysterieDev · Sep 13, 2021 · d253cd7 · d253cd7
1 parent 982fac0
commit d253cd7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/public/cookiebanner-index.min.js b/public/cookiebanner-index.min.js
diff --git a/solid-frontend-dev/package.json b/solid-frontend-dev/package.json
@@ -1,6 +1,6 @@
 {
     "name": "vite-template-solid",
-    "version": "1.0.1",
+    "version": "1.0.2",
     "description": "",
     "scripts": {
         "start": "vite",

diff --git a/solid-frontend-dev/src/banner-handling.ts b/solid-frontend-dev/src/banner-handling.ts
@@ -32,7 +32,9 @@ export function handleFinishedConsentInteraction(category: CookieCategory) {
     setConsentFunCookie(false);
   }
   if (category === CookieCategory.marketing) {
+    setConsentFunCookie(true);
     setConsentMarCookie(true);
+    consent.fun = true;
     consent.mar = true;
   } else {
     setConsentMarCookie(false);

diff --git a/solid-frontend-dev/src/consent-handling.ts b/solid-frontend-dev/src/consent-handling.ts
@@ -20,13 +20,13 @@ export function setConsentReqCookie() {
   });
 }
 export function setConsentFunCookie(allowed: boolean) {
-  return Cookies.set(consentMarCookie, allowed ? "TRUE" : "FALSE", {
+  return Cookies.set(consentFunCookie, allowed ? "TRUE" : "FALSE", {
     expires: consentDurationInDays,
   });
 }
 
 export function setConsentMarCookie(allowed: boolean) {
-  return Cookies.set(consentFunCookie, allowed ? "TRUE" : "FALSE", {
+  return Cookies.set(consentMarCookie, allowed ? "TRUE" : "FALSE", {
     expires: consentDurationInDays,
   });
 }