Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server-portal): return when Routes df is not found #343

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Tzal3x
Copy link
Collaborator

@Tzal3x Tzal3x commented Jan 7, 2025

There was an issue in the cases when a Routes dynamic field was not found, an exception would be thrown instead of showing a warning and returning undefined a.k.a. an implication that the df was not found.

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 4:28pm
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 4:28pm
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 4:28pm

@Tzal3x Tzal3x self-assigned this Jan 7, 2025
@Tzal3x Tzal3x added the bug Something isn't working label Jan 7, 2025
Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #343 will not alter performance

Comparing alextzimas/sew-7-error-500-on-sp-tnetblocksitenet (66aa55f) with main (1b59b85)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@giac-mysten giac-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Tzal3x Tzal3x merged commit cae751f into main Jan 7, 2025
21 checks passed
@Tzal3x Tzal3x deleted the alextzimas/sew-7-error-500-on-sp-tnetblocksitenet branch January 7, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants