Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align response formats with Walrus #336

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

mlegner
Copy link
Collaborator

@mlegner mlegner commented Dec 22, 2024

I modified some response formats in Walrus a bit carelessly in https://github.com/MystenLabs/walrus/pull/1324 and included this in the 1.7.3 release. Unfortunately this broke the site-builder... 😬

Would be nice to merge this into main and testnet.

Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 2:49pm
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 2:49pm
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 2:49pm

@mlegner mlegner enabled auto-merge (squash) December 22, 2024 14:49
Copy link

codspeed-hq bot commented Dec 22, 2024

CodSpeed Performance Report

Merging #336 will not alter performance

Comparing ml/fix-response-formats (1e4e6c3) with main (090ac9a)

Summary

✅ 3 untouched benchmarks

Copy link
Collaborator

@Tzal3x Tzal3x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @mlegner !

@mlegner mlegner merged commit 8719f8f into main Dec 22, 2024
21 checks passed
@mlegner mlegner deleted the ml/fix-response-formats branch December 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants