refactor(common-lib): use a more object-oriented-programming approach #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #326 will not alter performanceComparing Summary
|
Tzal3x
force-pushed
the
alextzimas/refactor-common-lib-move-to-ooo
branch
from
c094438 to
e7771ef
Compare
Tzal3x
force-pushed
the
alextzimas/refactor-common-lib-move-to-ooo
branch
from
7c33313 to
34ea37d
Compare
giac-mysten
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Awesome! this is definitely in the right direction! Thank you @Tzal3x .
A few questions and suggestions on ways to improve further.
A utility class that makes it safer to load the environment variables of the project. By using this class, we can ensure that the environment variables are loaded correctly and their data types are correct. --------- Co-authored-by: giac-mysten <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Update its' functions to depict the new name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that we need more flexibility as more features are coming in. Closes SEINT-428.
Moving on to an object-oriented approach by defining some classes and composing new ones based on them using the composition pattern will help us achieve that.
This way we can avoid spiraling down to multiple
if-elseclauses whenever a new feature request is coming.In upcoming PRs, we can create a
PageFetcherFactoryclass that generates a differentpageFetcherwhich will contain different rpcURLs, domain resolution logic etc based on the type of site (based on the allowlist) that we will serve.Changelog
PageFetcherclass.ResourceFetcherclass.WalrusSitesRouterclass.rpcSelectoris no longer a singleton. A differentRPCSelectorcan be used for: suin resolution, resource fetching and routes fetching without adding complex conditional flow control in thecommon/library's code.