feat(portal): Add support for tlds and suins subnames #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
2 times, most recently
from
0c5eb9e to
2a53bed
Compare
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
from
2a53bed to
3ba7ffc
Compare
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
from
3ba7ffc to
0babe74
Compare
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
from
0babe74 to
89002f1
Compare
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
from
89002f1 to
dafb3b8
Compare
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
from
dafb3b8 to
edac936
Compare
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
from
edac936 to
2dc65c3
Compare
mlegner
reviewed
Jul 22, 2024
|
I still need to check if the suins subnames work as expected. |
Urls should be like: 'https://subname.suinsname.localhost:8080' Not like: 'https://suinsname.subname.localhost:8080'
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
2 times, most recently
from
f7d8ea6 to
bb89489
Compare
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
from
bb89489 to
76d204d
Compare
Tzal3x
force-pushed
the
26-add-support-for-longer-tlds-such-as-couk
branch
from
76d204d to
594c9c4
Compare
1 task
Each parse-domain release comes up with a specific public suffix list. We use a fixed version temporarily, until the walrus.site gets added to the list, and the domain_parsing.ts code gets updated.
Tzal3x
changed the title
giac-mysten
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thanks @Tzal3x ! just left one comment open about merging the two functions. Please go ahead and merge if you think it is not necessary 👍
Co-authored-by: giac-mysten <[email protected]>
giac-mysten
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently supporting only a pattern of domains like this
0x123.walrus.sites.This PR makes it possible to:
0x123.localhost:8080,0x123.walrus.co.uksubsubname.subname.suinsname.walrus.sitesConnected issues:
co.uk#26