Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay notify_randomness_in_checkpoint until checkpoint is committed #21031

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

mystenmark
Copy link
Contributor

This ensures that we do not stop random partial sig transmission until the randomness update is durably committed to disk

@mystenmark mystenmark requested a review from a team as a code owner January 31, 2025 04:37
@mystenmark mystenmark requested a review from aschran January 31, 2025 04:37
@mystenmark mystenmark temporarily deployed to sui-typescript-aws-kms-test-env January 31, 2025 04:37 — with GitHub Actions Inactive
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 7:10pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 7:10pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 7:10pm

@mystenmark mystenmark force-pushed the mlogan-delay-notify-randomness branch from 98d69d2 to 52f2356 Compare January 31, 2025 19:09
@mystenmark mystenmark temporarily deployed to sui-typescript-aws-kms-test-env January 31, 2025 19:09 — with GitHub Actions Inactive
@mystenmark mystenmark merged commit 2de66e1 into main Jan 31, 2025
47 checks passed
@mystenmark mystenmark deleted the mlogan-delay-notify-randomness branch January 31, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants