-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move][move-vm][rewrite][cleanup 4/n] Convert AST indicies into VMPointers #21028
Open
cgswords
wants to merge
5
commits into
cgswords/vm_arena_limits
Choose a base branch
from
cgswords/vm_pointer_exec
base: cgswords/vm_arena_limits
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 31, 2025 03:25 — with
GitHub Actions
Inactive
tzakian
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely amazing! So so so clean
// interpreter. It's the only API known to the interpreter and it's tailored to the interpreter | ||
// needs. | ||
#[derive(Debug)] | ||
pub(crate) struct ModuleDefinitionResolver { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cgswords
force-pushed
the
cgswords/vm_arena_limits
branch
from
January 31, 2025 23:57
2bd2b44
to
ecef58b
Compare
cgswords
force-pushed
the
cgswords/vm_pointer_exec
branch
from
January 31, 2025 23:58
26ae2b2
to
1417a14
Compare
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
January 31, 2025 23:58 — with
GitHub Actions
Inactive
cgswords
changed the title
[move][move-vm] Convert AST indicies into VMPointers
[move][move-vm][rewrite][cleanup 4/n] Convert AST indicies into VMPointers
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is says on the tin
Test plan
Test suite still runs, plus tracing works (afterI disabled optimizations).
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.