Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move][move-vm][rewrite][cleanup 4/n] Convert AST indicies into VMPointers #21028

Open
wants to merge 5 commits into
base: cgswords/vm_arena_limits
Choose a base branch
from

Conversation

cgswords
Copy link
Contributor

Description

What is says on the tin

Test plan

Test suite still runs, plus tracing works (afterI disabled optimizations).


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 0:06am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2025 0:06am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2025 0:06am

@cgswords cgswords temporarily deployed to sui-typescript-aws-kms-test-env January 31, 2025 03:25 — with GitHub Actions Inactive
Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely amazing! So so so clean

// interpreter. It's the only API known to the interpreter and it's tailored to the interpreter
// needs.
#[derive(Debug)]
pub(crate) struct ModuleDefinitionResolver {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgswords cgswords force-pushed the cgswords/vm_arena_limits branch from 2bd2b44 to ecef58b Compare January 31, 2025 23:57
@cgswords cgswords force-pushed the cgswords/vm_pointer_exec branch from 26ae2b2 to 1417a14 Compare January 31, 2025 23:58
@cgswords cgswords temporarily deployed to sui-typescript-aws-kms-test-env January 31, 2025 23:58 — with GitHub Actions Inactive
@cgswords cgswords changed the title [move][move-vm] Convert AST indicies into VMPointers [move][move-vm][rewrite][cleanup 4/n] Convert AST indicies into VMPointers Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants