Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] New move-model-2 (currently unused) #20854

Merged
merged 58 commits into from
Jan 13, 2025

Conversation

tnowacki
Copy link
Contributor

Description

  • Adds a new move-model that works over the compiler's ProgramInfo

Test plan

👀
Not yet used


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

tnowacki and others added 30 commits April 24, 2024 11:16
## Description 

first commit: build failed I assume running docgen. It still fails ;)
but now on the `todo` for the docs.

second commit: introduces a compiled model. Things are not hooked up yet
but they will as soon as I sync with people

## Test plan 

hope and faith

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:13pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 7:13pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 7:13pm

@@ -0,0 +1,6 @@
warning[W01004]: invalid documentation comment
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't need to be in this PR, but oh well

@@ -0,0 +1,147 @@
// Copyright (c) The Move Contributors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't need to be in this PR but here it is 🤷

external-crates/move/crates/move-core-types/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@dariorussi dariorussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I forgot yesterday. It looks good and what we talked about a while ago.
thanks

@tnowacki tnowacki merged commit bac61e3 into MystenLabs:main Jan 13, 2025
47 checks passed
@tnowacki tnowacki deleted the move-model-2-land branch January 13, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants