[indexer-alt] Fix comments in pruner to
#20740
Open
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
wlmyng
reviewed
Dec 27, 2024
There was a problem hiding this comment.
I'm not sure if this really is a bug that needs fixing though
When pruning, we operate on [from, to), and then update watermark.pruner_hi = to, so the next chunk starts exactly where we left off. We also have a wait period in the earlier lines (2) so that we don't prune until straggling reads have largely finished
and the half-open intervals help avoid potential off-by-one errors and other confusion around pruning and read boundaries
We could instead adjust the doc comment on prune() in the Handler trait to reflect that to should be exclusive
lxfind
force-pushed
the
indexer-alt-fix-pruner-to
branch
from
c073bab to
cf003af
Compare
lxfind
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
Sounds good. Updated comments instead. |
lxfind
changed the title
toto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarified in the doc comment for
prunethattoshould be exclusive instead of inclusive.Also updated the prune loop to make it clearer.
Test plan
We probably want to write some tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.