Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Remove spec syntax and ignore new-style specs #20687

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cos
Copy link

@cos cos commented Dec 18, 2024

Description

  • Remove the deprecated spec and invariant keywords, and associated data structures.
  • Add functionality to ignore new-style specs. Similar to test_only, but more extensive, covering system code as well.

See this test and other files in the same directory for examples of filtered out code.

Test plan

  • Tests for the removed specs. They now throw "unrecognized syntax" errors instead of deprecation.
  • Tests for the filtering; code still compiling even when mentioning specs.

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:35pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 10:35pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 10:35pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 10:35pm

@cos
Copy link
Author

cos commented Dec 18, 2024

@tzakian, I see you are a reviewer for #20339, any chance we could get CI to run on this PR? It contains a subset of the changes.

@cos cos temporarily deployed to sui-typescript-aws-kms-test-env December 18, 2024 22:57 — with GitHub Actions Inactive
@cos cos changed the title Spec cleanup and ignore [move] Remove spec syntax and ignore new-style specs Dec 19, 2024
@cos
Copy link
Author

cos commented Dec 19, 2024

Thanks! Could we get another run?

@cos cos temporarily deployed to sui-typescript-aws-kms-test-env December 20, 2024 03:34 — with GitHub Actions Inactive
@stefan-mysten stefan-mysten self-assigned this Dec 20, 2024
@dariorussi
Copy link
Contributor

@cos do I understand it correctly that this is only the change that you would like to upstream to the main repo to push your code to the move nursery?

@cos
Copy link
Author

cos commented Dec 20, 2024

@dariorussi yes, these are the only changes -- we might follow up with a minor PR in case we missed something.

Just pushed again, fixed a bug and renamed "verify" to "spec" to reduce any confusion with signature verification.

@cos cos temporarily deployed to sui-typescript-aws-kms-test-env December 21, 2024 00:01 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants