[Indexer] Add synthetic ingestion and benchmark framework #19899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lxfind
force-pushed
the
sui-synthetic-ingestion
branch
from
f548742 to
05e9335
Compare
lxfind
force-pushed
the
sui-synthetic-ingestion
branch
from
05e9335 to
af9f43e
Compare
gegaowp
approved these changes
Oct 18, 2024
| @@ -160,7 +160,7 @@ impl<W: Worker + 'static> WorkerPool<W> { | |||
|
|
|||
| // Wait for all workers to finish | |||
| for join_handle in join_handles { | |||
| join_handle.await.expect("worker thread panicked"); | |||
| let _ = join_handle.await; | |||
There was a problem hiding this comment.
why do we need this, presumably if workers exit gracefully due to cancel, the behavior before & after is the same?
There was a problem hiding this comment.
That wasn't needed. Forgot to remove. Thanks!
lxfind
force-pushed
the
sui-synthetic-ingestion
branch
from
af9f43e to
52e42f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two things:
Test plan
Added an e2e test.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.