feat: add session based passkey authenticator #18817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
joyqvq
force-pushed
the
session-based-passkey
branch
from
92fc262 to
278a399
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
session-based-passkey
branch
from
278a399 to
3edd93f
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
session-based-passkey
branch
from
1855078 to
bafe2f2
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
session-based-passkey
branch
from
bafe2f2 to
4cb3e8e
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
session-based-passkey
branch
from
4cb3e8e to
7e47e55
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
force-pushed
the
session-based-passkey
branch
from
7e47e55 to
73cb473
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
requested review from
mystenmark,
patrickkuo,
kchalkias and
benr-ml
as code owners
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
reviewed
Dec 5, 2024
There was a problem hiding this comment.
One UX concern i have with passkeys in general, and especially with the session based passkey version, is address derivation.
It feels odd to me to have and r1 key, passkey, and passkey session to all have different on chain addresses despite using the same exact priv/pub key pair at the end of the day. I can maybe understand having a separation between bare r1 and passkey, but the separation between passkey and passkey session seems odd to me.
I'd love to hear @kchalkias 's thoughts on this if possible.
Now while this may feel odd to me, I don't have a strong stance on us doing one thing vs the other and if we want to be more conservative by having this separation I'd be content with that
joyqvq
force-pushed
the
session-based-passkey
branch
from
cd9518a to
3c05da3
Compare
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sui-foundation/sips#36
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.