Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bridge] let monitor handle emergecny op #18791

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

longbowlu
Copy link
Contributor

@longbowlu longbowlu commented Jul 25, 2024

Description

as title. Note the actual usage of the watch channel hasn't been wired up in ActionExecutor. It will be in the next PR.

Test plan

unit tests


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 9:16pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2024 9:16pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2024 9:16pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2024 9:16pm

@longbowlu longbowlu force-pushed the monitor-handle-emergency-op branch from b32b7ac to f0b425e Compare July 25, 2024 07:14
@longbowlu longbowlu changed the title let monitor handle emergecny op [bridge] let monitor handle emergecny op Jul 25, 2024
@longbowlu longbowlu marked this pull request as ready for review July 25, 2024 07:15
Copy link
Contributor

@patrickkuo patrickkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longbowlu longbowlu force-pushed the monitor-handle-blocklist branch 2 times, most recently from 0070dc9 to 39671ef Compare July 26, 2024 20:14
Base automatically changed from monitor-handle-blocklist to main July 26, 2024 20:53
@longbowlu longbowlu force-pushed the monitor-handle-emergency-op branch from f0b425e to 8bb6df8 Compare July 26, 2024 21:10
@longbowlu longbowlu enabled auto-merge (squash) July 26, 2024 21:20
@longbowlu longbowlu merged commit 50a0d38 into main Jul 26, 2024
49 checks passed
@longbowlu longbowlu deleted the monitor-handle-emergency-op branch July 26, 2024 21:36
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
## Description 

as title. Note the actual usage of the watch channel hasn't been wired
up in ActionExecutor. It will be in the next PR.

## Test plan 

unit tests

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants