Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suiop][incidents] add --with-priority flag #18673

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

after-ephemera
Copy link
Member

Description

enable limiting incident results to those with a priority set via the --with-priority/-p flag.

Test plan

» cargo run --bin suiop -- i r -p     
    Finished dev [unoptimized + debuginfo] target(s) in 0.43s
     Running `/Users/jordankylejensen/mysten/sui/target/debug/suiop i r -p`
2433: (2d) P0 dummy incident
3135: (2d) P2 [FIRING:2] incident for something
3134: (2d) P2 [FIRING:2] redacted

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@after-ephemera after-ephemera requested review from pei-mysten and a team July 15, 2024 17:59
Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Jul 15, 2024 5:59pm
sui-kiosk ⬜️ Ignored (Inspect) Jul 15, 2024 5:59pm
sui-typescript-docs ⬜️ Ignored (Inspect) Jul 15, 2024 5:59pm

@after-ephemera after-ephemera merged commit 15acca3 into main Jul 15, 2024
50 checks passed
@after-ephemera after-ephemera deleted the jkj/suiop-i-with-priority branch July 15, 2024 18:55
tx-tomcat pushed a commit to tx-tomcat/sui-network that referenced this pull request Jul 29, 2024
## Description 

enable limiting incident results to those with a priority set via the
`--with-priority`/`-p` flag.

## Test plan 

```
» cargo run --bin suiop -- i r -p     
    Finished dev [unoptimized + debuginfo] target(s) in 0.43s
     Running `/Users/jordankylejensen/mysten/sui/target/debug/suiop i r -p`
2433: (2d) P0 dummy incident
3135: (2d) P2 [FIRING:2] incident for something
3134: (2d) P2 [FIRING:2] redacted
```

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants