Skip to content

Commit

Permalink
[core] remove checkpoint executor unit testss (#20624)
Browse files Browse the repository at this point in the history
## Description 

Unit testing checkpoint executor does not provide sufficient signal
compared to end to end simtests to warrant their continued existence. As
the system has evolved, the assumptions in these tests have all been
broken at some point or another, causing them to fail or become flaky.
Removing.

## Test plan 

👀 

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
  • Loading branch information
williampsmith authored Jan 3, 2025
1 parent e17b8fd commit fa3ecc3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 407 deletions.
3 changes: 0 additions & 3 deletions crates/sui-core/src/checkpoints/checkpoint_executor/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ use crate::{
mod data_ingestion_handler;
pub mod metrics;

#[cfg(test)]
pub(crate) mod tests;

type CheckpointExecutionBuffer = FuturesOrdered<
JoinHandle<(
VerifiedCheckpoint,
Expand Down
Loading

0 comments on commit fa3ecc3

Please sign in to comment.