Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[trace-view] Fixed skipping same line instructions (#19812)
## Description This PR implements a more principled way to handle skipping instructions located on the same source code line for a smoother user experience. The main issue is handling call instructions, particularly if more than one of them is located on the same source code line. If not handled properly, the following effects could take place - if a call instruction was preceded by another instruction on the same source code line, when executing `step` action, the user would have to click `step` button twice on the same line to actually step into the call making an impression that the debugger is somehow stuck (or at least stuttering) - if more than one call instruction was on the same line, two things could happen: - executing the `next` action would not skip over all calls but only over a single one instead (the user would have to click `next` button multiple times to get to the next line) - executing the `step` would cause control flow to immediately enter the subsequent call on the same line instead of waiting for another `step` command from the user This PR also removes code related to stepping backwards in the trace as it's not being used nor maintained making a false impression that it's simply disabled and ready to roll ## Test plan Tested manually that the scenarios described above are handled correctly
- Loading branch information