Top Level Groups Enumeration #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 17, 2024 11:27
+added a WhereNotNull IEnumerable extension *also changed the list collection type to an immutable array
|
rebased on dev and removed the doc commits from the other pull request |
Noggog
requested changes
Oct 19, 2024
| @@ -4,6 +4,11 @@ namespace Mutagen.Bethesda; | |||
|
|
|||
| internal static class EnumerableExt | |||
| { | |||
| public static IEnumerable<T> WhereNotNull<T>(this IEnumerable<T?> enumer) | |||
There was a problem hiding this comment.
Already got an extension like this over in https://github.com/Noggog/CSharpExt/blob/89a5e0918ae8a212b592b890a5b62ca1209f2120/Noggog.CSharpExt/Extensions/EnumerableExt.cs#L257
But I do like the Where__ naming better. Feel free to open a PR over there, and mark the old ones obsolete
|
Ah, i can handle the small tweaks. Like i mentioned, gonna remove the new WhereNotNull method, but feel free to add to CSharpExt if you feel inspired to do so |
Noggog
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+added WhereNotNull IEnumerable Extension
+added GetTopLevelMajorRecordTypes to MajorRecordTypeEnumerator
+added to cheatsheat
*changed cache list type to immutableArray