NumLanguage bugfix

Mutagen-Modding · Jan 14, 2024 · e31caf0 · e31caf0
1 parent 254a02d
commit e31caf0
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/Mutagen.Bethesda.Core.UnitTests/Strings/TranslatedStringTests.cs b/Mutagen.Bethesda.Core.UnitTests/Strings/TranslatedStringTests.cs
@@ -336,6 +336,16 @@ public override TranslatedString Create(params KeyValuePair<Language, string>[]
 [Collection("TranslatedString")]
 public class TranslatedString_ByLookup : ATranslatedStringTests
 {
+    [Fact]
+    public void NumLanguagesReturnsMany()
+    {
+        TranslatedString.DefaultLanguage = Language.English;
+        ITranslatedString str = Create(
+            new KeyValuePair<Language, string>(Language.English, EnglishString),
+            new KeyValuePair<Language, string>(Language.French, FrenchString));
+        str.NumLanguages.Should().Be(2);
+    }
+
     public class ManualStringsLookup : IStringsFolderLookup
     {
         private readonly StringsSource _source;

diff --git a/Mutagen.Bethesda.Core/Strings/TranslatedString.cs b/Mutagen.Bethesda.Core/Strings/TranslatedString.cs
@@ -68,7 +68,14 @@ public string? String
         set => Set(TargetLanguage, value);
     }
 
-    public int NumLanguages => _localization?.Count ?? 1;
+    public int NumLanguages
+    {
+        get
+        {
+            ResolveAllStringSources();
+            return _localization?.Count ?? 1;
+        }
+    }
 
     private static TranslatedString _empty = new(Language.English, string.Empty);
     public static ITranslatedStringGetter Empty => _empty;
@@ -273,7 +280,7 @@ internal void ResolveAllStringSources()
                 }
                 else
                 {
-                    _localization[lang] = null;
+                    _localization.Remove(lang);
                 }
             }
             StringsLookup = null;