Skip to content

Commit

Permalink
GenderedItemBinaryOverlay.Factory male parameter marked optional
Browse files Browse the repository at this point in the history
  • Loading branch information
Noggog committed Dec 23, 2023
1 parent cde4767 commit 6908d03
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ internal static class GenderedItemBinaryOverlay
BinaryOverlayFactoryPackage package,
Func<OverlayStream, BinaryOverlayFactoryPackage, TypedParseParams, T> creator,
RecordTypeConverter femaleRecordConverter,
RecordTypeConverter maleRecordConverter,
RecordTypeConverter? maleRecordConverter = null,
bool shortCircuit = true,
bool parseNonConvertedItems = false)
where T : class
Expand All @@ -65,7 +65,7 @@ internal static class GenderedItemBinaryOverlay
if (stream.Complete) break;
var subHeader = stream.GetSubrecordHeader();
var recType = subHeader.RecordType;
if (maleRecordConverter.ToConversions.TryGetValue(recType, out var _))
if (maleRecordConverter != null && maleRecordConverter.ToConversions.TryGetValue(recType, out var _))
{
maleObj = creator(stream, package, new TypedParseParams(
lengthOverride: null,
Expand Down

0 comments on commit 6908d03

Please sign in to comment.