Rebase Overlay on ILCsoft master in view of pushing muon collider changes upstream #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The starting integration time was hardcoded to -0.25ns. Hits earlier than that time were removed. However, if vertex smearing is enabled in time, then we may see legitimate hits earlier than that (for FCC, the smearing width is about 1.9 ns). Add a property to set this value, rather then hardcoding it.
…on times configured
madbaron
changed the title
|
Is this all the changes? In that case we could bring this back to iLCSoft pretty much immediately, I would say. edit: Sorry, I was confused. This are the changes in ILCSoft, that are not yet in MuonColliderSoft. The other direction might look different. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases MuonColliderSoft/Overlay on the master of ILCSoft/Overlay in view of pushing the muon collider-related changes upstream.
Adding @tmadlener because why not
BEGINRELEASENOTES
ENDRELEASENOTES