Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector updates: holes and existence of TrackState at caloface #17

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Selector updates: holes and existence of TrackState at caloface #17

merged 9 commits into from
Nov 27, 2024

Conversation

madbaron
Copy link

BEGINRELEASENOTES

  • Added option to set maximum number of holes on track
  • Added option to check existence of trackstate at calo surface

ENDRELEASENOTES

tmadlener
tmadlener reviewed Nov 27, 2024
View reviewed changes
Copy link

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this can also go in as it is now, but I have one potential improvement and some nitpicking below.

source/Utils/src/FilterTracks.cc Outdated Show resolved Hide resolved
source/Utils/src/FilterTracks.cc Outdated Show resolved Hide resolved
@madbaron madbaron requested a review from tmadlener November 27, 2024 12:28
@madbaron
Copy link
Author

Ok now the package actually compiles (we'll have to clean up the tests..)

@tmadlener
Copy link

I have opened #20 that backports iLCSoft#71 that should fix all the noise that we currently see in the CI workflows.

@madbaron madbaron merged commit ddb43d7 into MuonColliderSoft:master Nov 27, 2024
5 checks passed
@madbaron madbaron deleted the selector_updates branch November 27, 2024 13:37
@madbaron
Copy link
Author

GGWP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madbaron @tmadlener