Add max health shareable. #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwoo1110
added
PR: Enhancement
|
Test build: |
dumptruckman
reviewed
Mar 3, 2021
| /** | ||
| * Player max health identifier. | ||
| */ | ||
| public static final String PLAYER_MAX_HEALTH = "mhp"; |
There was a problem hiding this comment.
Perhaps a slightly more description string? maxHp or something?
There was a problem hiding this comment.
Yea possible, I was just following how the other stats named, such as Total experience being txp. But if you prefer maxHp instead, will change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into the issue of altered max health causing issues, (#415) I realised we should actually have a max health sharable to better facility the change in max health between worlds.