Skip to content

Commit

Permalink
Added TODOs in github actions workflow YAML file
Browse files Browse the repository at this point in the history
Reminder for things to change as per master branch of e-mission-server once changes are finalized.
  • Loading branch information
Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed May 3, 2024
1 parent 6eebf87 commit e760598
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/fetch_runID.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
For e-mission-server: id = 35580278
'''
download_url = "https://api.github.com/repos/MukuFlash03/e-mission-server/actions/workflows/75506902/runs"
# TODO: Comment the above line and Uncomment the below line representing the original emission repo
# download_url = "https://api.github.com/repos/e-mission/e-mission-server/actions/workflows/35580278/runs"
logging.debug("About to fetch workflow runs present in docker image workflow present in e-mission-server from %s" % download_url)
r = requests.get(download_url)
Expand All @@ -48,6 +49,7 @@

workflow_runs = workflow_runs_json["workflow_runs"]
if workflow_runs:
# TODO: Change the head_branch name which identifies only e-mission-server runs triggered by this branch
successful_runs = [run for run in workflow_runs \
if run["status"] == "completed" and \
run["conclusion"] == "success" and \
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/image_build_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ jobs:
- name: Download artifact
uses: actions/download-artifact@v4
with:
# TODO: Create a token with basic repo permissions
name: docker-image-tag
github-token: ${{ secrets.GH_PAT_TAG }}
repository: MukuFlash03/e-mission-server
Expand Down Expand Up @@ -133,7 +134,7 @@ jobs:
git config --local user.email "[email protected]"
git config --local user.name "GitHub Action"
git add .env
git commit -m "Updated docker image tag in .env to the latest timestamp: ${{ env.DOCKER_IMAGE_TAG_2 }}"
git commit -m "Updated docker image tag in .env to the latest timestamp"
git push origin
- name: docker login
Expand Down
2 changes: 1 addition & 1 deletion viz_scripts/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# python 3
# Please change once all PR changes are final, so it reads from shankari/e-mission-server
# TODO: Please change once all PR changes are final, so it reads from shankari/e-mission-server
# FROM shankari/e-mission-server:master_2024-02-10--19-38
ARG DOCKER_IMAGE_TAG
FROM mukuflash03/e-mission-server:tags-combo-approach_${DOCKER_IMAGE_TAG}
Expand Down
2 changes: 1 addition & 1 deletion viz_scripts/docker/Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# python 3
# TODO: Please change once all PR changes are final, so it reads from shankari/e-mission-server
# FROM shankari/e-mission-server:master_2024-02-10--19-38
# Please change once all PR changes are final, so it reads from shankari/e-mission-server
ARG DOCKER_IMAGE_TAG
FROM mukuflash03/e-mission-server:tags-combo-approach_${DOCKER_IMAGE_TAG}

Expand Down

0 comments on commit e760598

Please sign in to comment.