Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger and debugLevel 2 Bug #47

Open
AndrewEdmonds11 opened this issue Feb 28, 2022 · 7 comments
Open

Trigger and debugLevel 2 Bug #47

AndrewEdmonds11 opened this issue Feb 28, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@AndrewEdmonds11
Copy link
Collaborator

AndrewEdmonds11 commented Feb 28, 2022

There is currently a bug that will throw an exception if you set:

physics.analyzers.TrkAnaNeg.FillTriggerInfo : true
physics.analyzers.TrkAnaNeg.debugLevel : 2

which causes the following error message:

%MSG-s ArtException:  PostEndJob 28-Feb-2022 07:59:28 CST ModuleEndJob
---- EventProcessorFailure BEGIN
  EventProcessor: an exception occurred during current event processing
  ---- EventProcessorFailure BEGIN
    EndPathExecutor: an exception occurred during current event processing
    ---- ScheduleExecutionFailure BEGIN
      Path: ProcessingStopped.
      ---- StdException BEGIN
        An exception was thrown while processing module TrkAnaTreeMaker/TrkAnaNeg run: 1210 subRun: 0 event: 2
        vector::_M_range_check: __n (which is 12) >= this->size() (which is 12)
      ---- StdException END
      Exception going through path end_path
    ---- ScheduleExecutionFailure END
  ---- EventProcessorFailure END
---- EventProcessorFailure END
%MSG
Art has completed and will exit with status 1.

It comes from these lines here: https://github.com/Mu2e/TrkAna/blob/514a2e62760f8727698f4cfcf79274fc20aa70f9/src/TrkAnaTreeMaker_module.cc#L692-L695
so I believe it's an issue with TriggerResultsNavigator. Once there is a fix, I will close this issue

@brownd1978
Copy link
Contributor

brownd1978 commented Feb 28, 2022 via email

@kutschke
Copy link
Contributor

@gianipez Andy just created a new issue, #47 , in the TrkAna repo. The error is TriggerResultsNavigator which I believe is your code so I have assigned the issue to you. Please have a look at this issue and let us know soon if you are indeed the right person to be assigned to this.

@AndrewEdmonds11
Copy link
Collaborator Author

Hi Andy, Those lines seem protected behind debuglevel>0. How is diaglevel>1 triggering them? Dave

Thanks for catching this, Dave. It is debugLevel = 2 that causes the issue, not diagLevel = 2. I will update the issue name and the opening comment

@AndrewEdmonds11 AndrewEdmonds11 changed the title Trigger and diagLevel 2 Bug Trigger and debugLevel 2 Bug Mar 1, 2022
@AndrewEdmonds11 AndrewEdmonds11 added the bug Something isn't working label Jun 13, 2024
@sam-grant
Copy link

Hi. I'm trying to establish whether or not this is still an issue.

If I naively append the lines

physics.analyzers.TrkAnaNeg.FillTriggerInfo : true
physics.analyzers.TrkAnaNeg.debugLevel : 2

to TrkAnaReco.fcl , and run it on a random Monte Carlo file (mcs.mu2e.CeEndpointOnSpillTriggered.MDC2020ae_best_v1_3.001210_00000014.art) it exits with status 0.

@AndrewEdmonds11 do you happen to remember which fcl file you were using? Were you using a different trigger path to the one in TrkAnaReco?

Thanks.

sam-grant pushed a commit to sam-grant/EventNtuple that referenced this issue Jun 28, 2024
@AndrewEdmonds11
Copy link
Collaborator Author

Thanks, Sam. I don't remember exactly which file this would have been for since it was a long time ago. Could you check whether the bug occurs when you change TrkAnaNeg to TrkAna in your configuration? (TrkAnaNeg is an old fhicl parameter). If you still don't see the bug, then I guess we close the issue and say it got solved somewhere else in the mean time...

@sam-grant
Copy link

Ah, if I use:

physics.analyzers.TrkAna.FillTriggerInfo : true
physics.analyzers.TrkAna.debugLevel : 2

Then I see a different error (related to the trigger info):

%MSG-s ArtException:  PostEndJob 10-Jul-2024 14:52:43 CDT ModuleEndJob
---- EventProcessorFailure BEGIN
  EventProcessor: an exception occurred during current event processing
  ---- EventProcessorFailure BEGIN
    EndPathExecutor: an exception occurred during current event processing
    ---- ScheduleExecutionFailure BEGIN
      Path: ProcessingStopped.
      ---- ProductNotFound BEGIN
        Found zero products matching all selection criteria
          C++ type: art::TriggerResults
          Module label: 'TriggerResults'
          Product instance name: ''
          Process name: 'Mix'
        The above exception was thrown while processing module TrkAnaTreeMaker/TrkAna run: 1210 subRun: 14 event: 1
      ---- ProductNotFound END
      Exception going through path end_path
    ---- ScheduleExecutionFailure END
  ---- EventProcessorFailure END
---- EventProcessorFailure END
%MSG
Art has completed and will exit with status 1.

But if I set FillTriggerInfo : false , then I see a similar "vector range check" error to the original one...

%MSG-s ArtException:  PostEndJob 10-Jul-2024 14:53:23 CDT ModuleEndJob
---- EventProcessorFailure BEGIN
  EventProcessor: an exception occurred during current event processing
  ---- EventProcessorFailure BEGIN
    EndPathExecutor: an exception occurred during current event processing
    ---- ScheduleExecutionFailure BEGIN
      Path: ProcessingStopped.
      ---- StdException BEGIN
        An exception was thrown while processing module TrkAnaTreeMaker/TrkAna run: 1210 subRun: 14 event: 1
        vector::_M_range_check: __n (which is 49043) >= this->size() (which is 1)
      ---- StdException END
      Exception going through path end_path
    ---- ScheduleExecutionFailure END
  ---- EventProcessorFailure END
---- EventProcessorFailure END
%MSG 

@AndrewEdmonds11
Copy link
Collaborator Author

Thanks, Sam. I guess for the first error we are just getting the wrong art::TriggerResults data product from the mcs file. Here are the ones I see in an MDS0 file:

            437306      0.000 art::TriggerResults_TriggerResults__Digitize.
            240786      0.000 art::TriggerResults_TriggerResults__cosmicsplitter.
            227342      0.000 art::TriggerResults_TriggerResults__CosmicS2.
            224734      0.000 art::TriggerResults_TriggerResults__Primary.
            178126      0.000 art::TriggerResults_TriggerResults__Reconstruct.

I guess we want Reconstruct rather than Mix so we should look for where that's set. I will open a new issue for that. Feel free to assign it to yourself if you want to take a look

The second one is a bit more of a mystery, I guess that we are entering a bit of code we shouldn't be when FillTriggerInfo is false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants