Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm old bug reports #162

Closed
AndrewEdmonds11 opened this issue Jun 17, 2024 · 5 comments
Closed

Confirm old bug reports #162

AndrewEdmonds11 opened this issue Jun 17, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AndrewEdmonds11
Copy link
Collaborator

We have a number of old open issues that are bug reports. This issue is to go through and work out which are still valid and need to be solved

@AndrewEdmonds11 AndrewEdmonds11 converted this from a draft issue Jun 17, 2024
@AndrewEdmonds11 AndrewEdmonds11 added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 17, 2024
@sam-grant
Copy link

I can take a look at this.

@AndrewEdmonds11 AndrewEdmonds11 moved this from Ready to In progress in Mu2e Ntuple Jun 26, 2024
@sam-grant
Copy link

I looked through a few old bug reports and tried to establish if they are still a problem. See my comments on each issue for more details!

Issue/47: I can produce a similar error using the latest TrkAna, so I think this is still a problem.
Issue/91: I can reproduce the error if I use TrkQualFilter, but this is being phased out so I think this issue can be closed.
Issue/167: This issue is not really a bug but a result of the way local tracker variables are stored in TrkAna, we discussed some different ways to handle this using uproot in the comments.
Issue/168: This is still a problem, but I think it may be a limitation of ROOT rather than a bug in TrkAna (although I'm not sure what causes it).

@AndrewEdmonds11
Copy link
Collaborator Author

Thanks, Sam! I will follow up on next steps for these in the issues themselves

@AndrewEdmonds11
Copy link
Collaborator Author

I've looked at a few more:

Issue #21: I couldn't recreate the bug but we should check that we can run on data-only files (i.e. with no MC information)
Issue #90: this was already done and so has been closed
Issue #93: the bestcrv branch has been removed so this is no longer an issue

@AndrewEdmonds11
Copy link
Collaborator Author

I don't see any more old issues to confirm so this is done

@github-project-automation github-project-automation bot moved this from In progress to Done in Mu2e Ntuple Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

2 participants